fix: adjust rollback_start_live update
#811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 13, 2025
This stack of pull requests is managed by Graphite. Learn more about stacking. |
rphmeier
reviewed
Feb 13, 2025
| @@ -237,8 +237,9 @@ impl Rollback { | |||
|
|
|||
| // NOTE: for now, if there is a pending truncate, we ignore everything else. | |||
| if let Some(pending_truncate) = pending_truncate { | |||
| let rollback_start_live = std::cmp::min(seglog.live_range().0 .0, pending_truncate); | |||
There was a problem hiding this comment.
the formatting here is a bit odd (same as before), but should be
seglog.live_range().0.0 without the extra space.
There was a problem hiding this comment.
Yes! I agree that formatting is weird, but it seems it is what the latest version of rustfmt wants. I disabled it and pushed without the extra space
There was a problem hiding this comment.
Apparently this is not considered acceptable by rustfmt at all, as you can see in this action failure.
I will keep the weird extra space, otherwise we should use something like #[rustfmt::skip] but I don't think it is worth it!
rphmeier
approved these changes
Feb 13, 2025
gabriele-0201
force-pushed
the
gm_torture_avoid_panic_in_workload_run
branch
from
af7063e to
a155287
Compare
gabriele-0201
force-pushed
the
gm_torture_rollback_open_panic
branch
from
3ab3af6 to
3f27ed4
Compare
When a rollback is going to erase all the commits, `rollback_start_live` will need to be equal to `pending_truncate`.
gabriele-0201
force-pushed
the
gm_torture_rollback_open_panic
branch
from
3f27ed4 to
d533eef
Compare
Base automatically changed from
gm_torture_avoid_panic_in_workload_run
to
master
February 14, 2025 09:04
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a rollback is going to erase all the commits,
rollback_start_livewill need to be equal topending_truncate.